Extract text with AI command #2191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitry-zaitsev
commented
Dec 14, 2024
| @@ -84,7 +84,7 @@ class Orchestra( | |||
| private val onCommandStart: (Int, MaestroCommand) -> Unit = { _, _ -> }, | |||
| private val onCommandComplete: (Int, MaestroCommand) -> Unit = { _, _ -> }, | |||
| private val onCommandFailed: (Int, MaestroCommand, Throwable) -> ErrorResolution = { _, _, e -> throw e }, | |||
| private val onCommandWarned: (Int, MaestroCommand) -> Unit = { _, _ -> }, | |||
There was a problem hiding this comment.
There is a bit of auto-reformatting in this class. The main relevant change is extractTextWithAICommand method
|
Not sure why detekt pushed so many styling changes 🤷 Perhaps these classes were not touched since the style changed? |
felipeduartea
approved these changes
Dec 15, 2024
| @@ -413,6 +415,26 @@ class Orchestra( | |||
| false | |||
| } | |||
|
|
|||
| private fun extractTextWithAICommand(command: ExtractTextWithAICommand): Boolean = runBlocking { | |||
| // Extract text from the screen using AI | |||
| if (ai == null) { | |||
There was a problem hiding this comment.
nit: Although this ai variable was not added now, it probably deserves a better name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing a
extractTextWithAIcommand that uses LLM to extract text form a screenshot. Some situations where it is useful:Usage Example